ThingerSmartConfig breaks deep sleep on esp8266

andrew · February 2, 2016, 2:21pm

Hi,

I think I’m getting close to making things work with SmartConfig and Thinger. For deep sleep functionality, one must connect the RST and D0 pins on the chip. However, on many dev boards they chose to wire the BUILTIN_LED to the D0 as well. Just check for yourself, the pins_arduino.h for multiple variants: https://github.com/esp8266/Arduino/tree/master/variants

Anyway, this causes all kinds of crazy crashes because attempting to write to D0 triggers resets and zombie state on recovery.

I suggest we have a way to have a way of disabling these (there’s another few lines down). Wouldn’t want to completely remove it, as it seems to be useful outside of a deep sleep context.

Help me understand the Thinger.io client library approach/idioms and I’ll send the PR I’d like to do better than a top-level #define

github.com

thinger-io/Arduino-Library/blob/master/src/ThingerSmartConfig.h#L35


#define THINGER_SMARTCONFIG_H


#include "ThingerClient.h"


#define WIFI_CONNECTION_TIMEOUT_MS 15000
#define IP_ADDRESS_TIMEOUT_MS 30000
#define SMART_CONFIG_WAIT_MS 60000


class ThingerSmartConfig : public ThingerClient {


public:
ThingerSmartConfig(const char* user, const char* device, const char* device_credential, bool use_led=true) :
        ThingerClient(client_, user, device, device_credential), use_led_(use_led)
{
    if(use_led_){
        pinMode(BUILTIN_LED, OUTPUT);
    }
}


~ThingerSmartConfig(){

alvarolb · February 2, 2016, 3:53pm

Never tested the deep sleep feature of ESP8266, but you must take into account that thinger will be sending a keep alive every 1 minute to ensure the device is connected. It is not a problem however for the client if the device is sleeping 10 minutes, and then waking up to stream a value, or call an endpoint. This should be working.

For the deep sleep feature and the smartconfig, I think it is possible to add a default parameter in the constructor after device credential initialized to true, so it can control when to use the BUILTIN_LED to notify the SmartConfig process.

Something like:

ThingerSmartConfig(const char* user, const char* device, const char* device_credential, bool use_led=true) :
        ThingerClient(client_, user, device, device_credential), led_(use_led)
{
    if(use_led){
        pinMode(BUILTIN_LED, OUTPUT);
    }
}

It is necessary to add the led_ attribute, and take care of it in other places where the BUILTIN_LED is used. I can modify this tonight, but if you want you can try it in the meantime

andrew · February 2, 2016, 3:55pm

I’ll strike a deal with you You update the codebase and I will add a doc section on deep sleep referencing the code. Need to take care of a number of things today before I can get back to coding.

alvarolb · February 2, 2016, 7:01pm

Done! I will work on that!. I would like to see your NodeMCU setup for deep sleep (hardware connections), so I can test it also. I thought it was necessary to jump a 0R resistor in the board to get the GPIO16, but maybe I am missing something…

andrew · February 2, 2016, 7:39pm

Zero-resistor is a direct wire connection. Those electrical engineers and their fancy terms, he he

I’ve documented things for others here https://github.com/aperepel/iot-esp8266-starter . Not my most proudest piece of c++, but hey! Check out the next iteration of the template too.

I have the SmartConfig working in that template fine on esp8266, but of course it can be packaged and refactored better (e.g. using that other WiFiConnector library).

alvarolb · February 3, 2016, 10:56pm

Let me know if it works now with the new header version

ThingerSmartConfig thing(USERNAME, DEVICE_ID, DEVICE_CREDENTIAL, false);

github.com

thinger-io/Arduino-Library/blob/master/src/ThingerSmartConfig.h

// The MIT License (MIT)
//
// Copyright (c) 2017 THINK BIG LABS SL
// Author: alvarolb@gmail.com (Alvaro Luis Bustamante)
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,

This file has been truncated. show original

andrew · February 4, 2016, 3:21pm

Works with the latest code, I’ll send through a doc update PR later today, hopefully.